resolve homework jv-salary-info #1236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Jun 7, 2024
Comment on lines
18
to
21
| SimpleDateFormat format = new SimpleDateFormat("dd.MM.yyyy"); | ||
| Date docDate = null; | ||
| Date fromDate = null; | ||
| Date toDate = null; |
There was a problem hiding this comment.
please review checklist of common mistakes and we can continue with review
Vasul-Pankiv
suggested changes
Jun 11, 2024
| int sum = 0; | ||
| for (String elementOfData : data) { | ||
| String[] elements = elementOfData.split(" "); | ||
| if (elements[1].equals(name)) { |
There was a problem hiding this comment.
What is 1? Make a constant with an informative name
| LocalDate fromDate = null; | ||
| LocalDate toDate = null; | ||
| try { | ||
| docDate = LocalDate.parse(elements[0], formatter);; |
| for (String elementOfData : data) { | ||
| String[] elements = elementOfData.split(" "); | ||
| if (elements[1].equals(name)) { | ||
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
There was a problem hiding this comment.
read common mistakes before sending your solution to review
| } | ||
| } | ||
| if (count == names.length - 1) { | ||
| result.append(name).append(" - ").append(sum); |
sarakhmen
suggested changes
Jun 11, 2024
| private static final int WORKING_HOUR = 2; | ||
| private static final int INCOME_PER_HOUR = 3; | ||
| private static final String SEPARATOR = " - "; | ||
| private static final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| StringBuilder result = new StringBuilder("Report for period " | ||
| + dateFrom + SEPARATOR + dateTo + "\n"); |
There was a problem hiding this comment.
please use System.lineSeparator instead of \n
Elena-Bruyako
suggested changes
Jun 12, 2024
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| StringBuilder result = new StringBuilder("Report for period " | ||
| + dateFrom + SEPARATOR + dateTo + System.lineSeparator()); |
There was a problem hiding this comment.
StringBuilder is used to avoid creating new String during the concatenation, so use append() method
| fromDate = fromDate.minusDays(1); | ||
| toDate = toDate.plusDays(1); | ||
| } catch (DateTimeParseException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
bad approach, it's better to throw an exception with informative message
okuzan
suggested changes
Jun 12, 2024
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| StringBuilder result = new StringBuilder("Report for period ").append(dateFrom) | ||
| .append(SEPARATOR).append(dateTo).append(System.lineSeparator()); |
There was a problem hiding this comment.
Suggested change
| .append(SEPARATOR).append(dateTo).append(System.lineSeparator()); | |
| .append(SEPARATOR).append(dateTo); |
Comment on lines
21
to
27
| if (count == names.length - 1) { | ||
| result.append(name).append(SEPARATOR).append(earnedMoneyByPerson); | ||
| } else { | ||
| result.append(name).append(SEPARATOR).append(earnedMoneyByPerson) | ||
| .append(System.lineSeparator()); | ||
| count++; | ||
| } |
There was a problem hiding this comment.
remove if-else, add lineseparator at the beginning, not the end of the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.